Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix playground #1681

Merged
merged 5 commits into from
Aug 2, 2024
Merged

fix playground #1681

merged 5 commits into from
Aug 2, 2024

Conversation

larsrickert
Copy link
Collaborator

@larsrickert larsrickert commented Aug 1, 2024 •
edited
Loading

fixes #1489

  • fix Module '"sit-onyx"' has no exported member 'OnyxHeadline' error
  • version selects: show "beta" or "latest" version initially instead of concrete version number
  • support search for version selects
  • persist selected onyx and typescript version (vue version is already persisted)

I created a bug report for the @vue/repl package: vuejs/repl#269

@larsrickert larsrickert requested a review from a team as a code owner August 1, 2024 11:28
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 11b748a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@BoppLi BoppLi self-assigned this Aug 1, 2024
BoppLi
BoppLi previously approved these changes Aug 1, 2024
View reviewed changes
apps/playground/src/composables/useStore.ts Show resolved Hide resolved
apps/playground/src/composables/useStore.ts Outdated Show resolved Hide resolved
@larsrickert larsrickert requested a review from BoppLi August 1, 2024 15:20
BoppLi
BoppLi approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@BoppLi BoppLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😊

@larsrickert larsrickert merged commit cfd1888 into main Aug 2, 2024
19 checks passed
@larsrickert larsrickert deleted the fix/1489-playground branch August 2, 2024 06:52
@larsrickert larsrickert mentioned this pull request Aug 2, 2024
Merged
larsrickert added a commit that referenced this pull request Aug 2, 2024
@larsrickert
chore: ignore @vue/repl in dependabot (#1687)
e1c58da 
Follow up for #1681

Ignore updates for `@vue/repl` until the bug is fixed. We need it to be
pinned to `4.2.1` for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoppLi BoppLi BoppLi approved these changes

Assignees

@BoppLi BoppLi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix playground doesn't seem to use the selected onyx version
2 participants
@larsrickert @BoppLi