Fix case sensitivity and update unit tests #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshriver
commented
Nov 24, 2020
mshriver
force-pushed
the
broken-capitalization
branch
from
e896e8b
to
cbaeac2
Compare
This can be observed by running `testimony -n --config tests/config-full.yaml validate tests` test_case_mismatch_case_insensitive_values will be flagged for the valid, case correct tokens CaseImportance and CaseAutomation
Thanks @mirekdlugosz for the patch in issue SatelliteQE#148 Just me stealing his code and committing it Resolves validation failing valid token values when case sensitivity is set to true
mshriver
force-pushed
the
broken-capitalization
branch
from
cbaeac2
to
04b276c
Compare
mshriver
changed the title
elyezer
approved these changes
Nov 24, 2020
|
Travis is taking to long I will go ahead and merge this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @mirekdlugosz for the patch suggestion in #148, I've included your change here.
Without the fix commit, you will see the following type of failure when validating the unit tests with
config-full.yamllike:testimony -n --config tests/config-full.yaml validate testsThe failure looks like the following - valid token values fail validation based on case sensitivity.
Fixes #148