Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Flatpak CLI support and CRUD case #17013

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Flatpak CLI support and CRUD case #17013

wants to merge 3 commits into from
+256 −0

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Nov 28, 2024 •
edited
Loading

Problem Statement

Satellite 6.17 introduces support for Flatpak content. We should introduce some automation around.

Solution

This PR just adds one test case for CRUD + scan and one test case to verify the scan finds all repos available in the remote index.

Related Issues

https://issues.redhat.com/browse/SAT-28471

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/cli/test_flatpak.py
Katello:
  katello: 11223
  hammer-cli-katello: 971

@vsedmik vsedmik added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Nov 28, 2024
@vsedmik vsedmik self-assigned this Nov 28, 2024
@vsedmik vsedmik requested a review from a team as a code owner November 28, 2024 18:34
@vsedmik vsedmik added the in progress This issue is being worked on label Nov 28, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented Nov 28, 2024 

trigger: test-robottelo
pytest: tests/foreman/cli/test_flatpak.py -k CRUD
Katello:
  katello: 11223
  hammer-cli-katello: 971

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9477
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_flatpak.py -k CRUD --external-logging
Test Result : ================== 1 passed, 9 warnings in 1239.53s (0:20:39) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 28, 2024
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 29, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented Nov 29, 2024 

trigger: test-robottelo
pytest: tests/foreman/cli/test_flatpak.py -k scan
Katello:
  katello: 11223
  hammer-cli-katello: 971

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9479
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_flatpak.py -k scan --external-logging
Test Result : ========== 1 passed, 1 deselected, 10 warnings in 1193.34s (0:19:53) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 29, 2024
synkd
synkd approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@synkd synkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. One non-blocking suggestion.

tests/foreman/cli/test_flatpak.py Outdated
assert 'Error: flatpak_remote not found' in str(e)


def test_scan(target_sat, function_org, function_product):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: what do you think about renaming this to test_scan_flatpak_remote? test_scan seems a bit too terse to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right @synkd, I'll update it.

I usually start writing a test case with some short name like test_dummie and update the name specifically later. The update didn't happen this time.

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@synkd synkd synkd approved these changes

@pondrejk pondrejk pondrejk approved these changes

Assignees

@vsedmik vsedmik

Labels
in progress This issue is being worked on No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsedmik @Satellite-QE @pondrejk @synkd