Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the diff between gha robottelo and nailgun #991

Closed

Conversation

omkarkhatavkar
Copy link

Description of changes

Describe in detail the changes made, and any potential impacts to callers.

Upstream API documentation, plugin, or feature links

Link to any relevant upstream API documentation that relates to the content of the PR.

Functional demonstration

Provide an execution of the modified code, with ipython code blocks or screen shots.
You can exercise the code as raw API calls or using any other method.

Your contribution should include updates to the unit tests, covering the modified portions or adding new coverage.

Example:

# Demonstrate functional Snapshot read in ipython
In [1]: from nailgun.entities import Snapshot
In [2]: Snapshot(host='sat.instance.addr.com', id='snap_uuid').read()
Out [2]: <read method result>
Additional Information

Any additional notes for reviewers, comments about the change, TODO lists on WIP PRs, etc.

@omkarkhatavkar omkarkhatavkar added the No-CherryPick PR doesnt need CherryPick to previous branches label Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4e4026f) 92.14% compared to head (f8411aa) 92.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #991   +/-   ##
=======================================
  Coverage   92.14%   92.14%           
=======================================
  Files           6        6           
  Lines        3043     3043           
=======================================
  Hits         2804     2804           
  Misses        239      239           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omkarkhatavkar omkarkhatavkar added CherryPick PR needs CherryPick to previous branches 6.12.z 6.13.z 6.14.z and removed No-CherryPick PR doesnt need CherryPick to previous branches labels Aug 31, 2023
@github-actions
Copy link

This pull request has not been updated in the past 45 days.

@github-actions github-actions bot added the Stale Stale issue or Pull Request label Oct 16, 2023
@github-actions
Copy link

This pull request is now being closed after stale warnings.

@github-actions github-actions bot closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.12.z 6.13.z 6.14.z CherryPick PR needs CherryPick to previous branches Stale Stale issue or Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants