Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add boolean field for default_content_http_proxy in HTTProxy entity #1254

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add boolean field for default_content_http_proxy in HTTProxy entity #1254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions nailgun/entities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5421,6 +5421,7 @@ def __init__(self, server_config=None, **kwargs):
'organization': entity_fields.OneToManyField(Organization),
'location': entity_fields.OneToManyField(Location),
'cacert': entity_fields.StringField(),
'default_content_http_proxy': entity_fields.BooleanField(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'default_content_http_proxy': entity_fields.BooleanField(),
'default_content': entity_fields.BooleanField(),

@Gauravtalreja1, could you provide some functional demonstration with ipython? I tried locally with packit VM for Katello/katello#11183 but I don't get the default_content_http_proxy on create nor on read back from API. We may need to add it to the ignore list if it's not returned.

Also, I didn't get the setting updated until I used default_content in the create call.

}
self._meta = {'api_path': 'api/v2/http_proxies'}
super().__init__(server_config=server_config, **kwargs)
Expand Down