Use session-scoped inventory by default

[synkd]

Currently, Manifester syncs its inventory multiple times while generating a manifest to ensure that the inventory data matches with the corresponding data in RHSM. For some use cases, though, this behavior is not desirable. Notably, in a CI scenario in which multiple workers share the same username_prefix setting, syncing the inventory with RHSM prevents those workers from running manifester delete --all at the end of each pipeline, as this could delete allocations that are still being used by other workers.

This PR addresses this issue by converting the default inventory behavior to not sync from RHSM unless a sync is explicitly invoked.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 suggestion.

The condition 'uuid not in alloc["uuid"]' should be 'uuid != alloc["uuid"]' to correctly filter out the allocation with the matching UUID.

Suggested change

	_dump_inventory_file(inventory_path, [alloc for alloc in inv if uuid not in alloc["uuid"]])
	_dump_inventory_file(inventory_path, [alloc for alloc in inv if uuid != alloc["uuid"]])

[JacobCallahan]

could this be simplified?

Suggested change

	def _dump_inventory_file(inventory_path, inventory):
	"""Write inventory data to local inventory file."""
	with inventory_path.open("w") as inventory_file:
	yaml.dump(inventory, inventory_file, allow_unicode=True)
	def _update_inventory(inventory_path, inventory, allocation):
	"""Add new allocation, remove and recreate inventory file."""
	inventory.append(allocation)
	inventory_path.unlink()
	inventory_path.touch()
	_dump_inventory_file(inventory_path, inventory)
	def _update_inventory(inventory_path, inventory, allocation):
	"""Add new allocation, remove and recreate inventory file."""
	inventory.append(allocation)
	inventory_path.unlink()
	inventory_path.touch()
	yaml.dump(inventory, inventory_path, allow_unicode=True)

[synkd]

@JacobCallahan Per the PyYAML docs, yaml.dump needs an open file in order to write to it directly. Your proposed changed throws an AttributeError: 'PosixPath' object has no attribute 'write'. Did you mean: 'drive'? when it tries to dump to the Path object. So we need a second line before yaml.dump to open the inventory file. I think it's slightly cleaner to move that action into a separate helper function since it gets used in three places, but that part isn't strictly necessary.