Initial commit for Ansible based Satellite6 Install and Configure. #4

kbidarkar · 2018-07-18T14:10:49Z

Added a partition-disk role
Added playbooks for sat63 and sat64

* Added a partition-disk role * Added playbooks for sat63 and sat64 Signed-off-by: Kedar Bidarkar <[email protected]>

kbidarkar · 2018-07-18T15:42:55Z

[First run for the host: sat64-rhel7] Below are the results for the partition-disk role while using the sat64 playbook.

 git_world  ansible-satellite6  ansible-playbook -i inventory playbooks/install/satellite_64.yml

PLAY [sat64] *****************************************************************************************************************************************************************************************************************************************************************************

TASK [Gathering Facts] *******************************************************************************************************************************************************************************************************************************************************************
ok: [sat64-rhel7]

TASK [partition-disk : include_tasks] ****************************************************************************************************************************************************************************************************************************************************
included: /home/kbidarka/git_world/ansible-satellite6/roles/partition-disk/tasks/remove_home_partition.yaml for sat64-rhel7

TASK [partition-disk : Unmount /home partition] ******************************************************************************************************************************************************************************************************************************************
changed: [sat64-rhel7]

TASK [partition-disk : Remove /home entry from /etc/fstab] *******************************************************************************************************************************************************************************************************************************
changed: [sat64-rhel7]

TASK [partition-disk : Remove /home Logical Volume] **************************************************************************************************************************************************************************************************************************************
changed: [sat64-rhel7] => (item={'key': 'home', 'value': {'size_g': '406.88', 'vg': 'rhel_cloud-qe-22'}})
skipping: [sat64-rhel7] => (item={'key': 'root', 'value': {'size_g': '50.00', 'vg': 'rhel_cloud-qe-22'}}) 
skipping: [sat64-rhel7] => (item={'key': 'swap', 'value': {'size_g': '7.88', 'vg': 'rhel_cloud-qe-22'}}) 

TASK [partition-disk : include_tasks] ****************************************************************************************************************************************************************************************************************************************************
included: /home/kbidarka/git_world/ansible-satellite6/roles/partition-disk/tasks/extend_root_partition.yaml for sat64-rhel7

TASK [partition-disk : Extend root partition LV to all available VG space] ***************************************************************************************************************************************************************************************************************
skipping: [sat64-rhel7] => (item={'key': 'home', 'value': {'size_g': '406.88', 'vg': 'rhel_cloud-qe-22'}}) 
changed: [sat64-rhel7] => (item={'key': 'root', 'value': {'size_g': '50.00', 'vg': 'rhel_cloud-qe-22'}})
skipping: [sat64-rhel7] => (item={'key': 'swap', 'value': {'size_g': '7.88', 'vg': 'rhel_cloud-qe-22'}}) 

TASK [partition-disk : Resize the root filesystem] ***************************************************************************************************************************************************************************************************************************************
skipping: [sat64-rhel7] => (item={'key': 'home', 'value': {'size_g': '406.88', 'vg': 'rhel_cloud-qe-22'}}) 
changed: [sat64-rhel7] => (item={'key': 'root', 'value': {'size_g': '50.00', 'vg': 'rhel_cloud-qe-22'}})
skipping: [sat64-rhel7] => (item={'key': 'swap', 'value': {'size_g': '7.88', 'vg': 'rhel_cloud-qe-22'}}) 

PLAY RECAP *******************************************************************************************************************************************************************************************************************************************************************************
sat64-rhel7                : ok=8    changed=5    unreachable=0    failed=0

[Re-run for the host sat63-rhel7]Also, tried re-running the partition-disk role using sat63 playbook.

 git_world  ansible-satellite6  ansible-playbook -i inventory playbooks/install/satellite_63.yml

PLAY [sat63] *****************************************************************************************************************************************************************************************************************************************************************************

TASK [Gathering Facts] *******************************************************************************************************************************************************************************************************************************************************************
ok: [sat63-rhel7]

TASK [partition-disk : include_tasks] ****************************************************************************************************************************************************************************************************************************************************
included: /home/kbidarka/git_world/ansible-satellite6/roles/partition-disk/tasks/remove_home_partition.yaml for sat63-rhel7

TASK [partition-disk : Unmount /home partition] ******************************************************************************************************************************************************************************************************************************************
ok: [sat63-rhel7]

TASK [partition-disk : Remove /home entry from /etc/fstab] *******************************************************************************************************************************************************************************************************************************
ok: [sat63-rhel7]

TASK [partition-disk : Remove /home Logical Volume] **************************************************************************************************************************************************************************************************************************************
skipping: [sat63-rhel7] => (item={'key': 'root', 'value': {'size_g': '262.68', 'vg': 'rhel_hp-dl380-gen9-5'}}) 
skipping: [sat63-rhel7] => (item={'key': 'swap', 'value': {'size_g': '15.69', 'vg': 'rhel_hp-dl380-gen9-5'}}) 

TASK [partition-disk : include_tasks] ****************************************************************************************************************************************************************************************************************************************************
included: /home/kbidarka/git_world/ansible-satellite6/roles/partition-disk/tasks/extend_root_partition.yaml for sat63-rhel7

TASK [partition-disk : Extend root partition LV to all available VG space] ***************************************************************************************************************************************************************************************************************
ok: [sat63-rhel7] => (item={'key': 'root', 'value': {'size_g': '262.68', 'vg': 'rhel_hp-dl380-gen9-5'}})
skipping: [sat63-rhel7] => (item={'key': 'swap', 'value': {'size_g': '15.69', 'vg': 'rhel_hp-dl380-gen9-5'}}) 

TASK [partition-disk : Resize the root filesystem] ***************************************************************************************************************************************************************************************************************************************
ok: [sat63-rhel7] => (item={'key': 'root', 'value': {'size_g': '262.68', 'vg': 'rhel_hp-dl380-gen9-5'}})
skipping: [sat63-rhel7] => (item={'key': 'swap', 'value': {'size_g': '15.69', 'vg': 'rhel_hp-dl380-gen9-5'}}) 

PLAY RECAP *******************************************************************************************************************************************************************************************************************************************************************************
sat63-rhel7                : ok=7    changed=0    unreachable=0    failed=0

Feel, it is better to also test re-run, just to avoid any issues while re-running the playbook on the same host.

chris1984

Looks good, left 1 comment

chris1984 · 2018-07-18T15:53:15Z

CONTRIBUTING.md

+```
+git clone [email protected]:yourname/ansible-satellite6
+cd ansible-satellite6
+git checkout -b your-branch-name


Should we have them add the remote so they can rebase easily and pull in new changes?

That suggestion is based on this link, https://help.github.com/articles/fork-a-repo/ :)

Ok, I will mark my comment approved then :)

omaciel · 2018-07-18T16:00:18Z

Was talking to @kbidarkar on IRC about the need to make sure that the underlying version of RHEL does not affect the outcome of this task. Like setting up the firewall rules on RHEL 6 x RHEL 7 :)

flatfender · 2018-07-18T16:10:32Z

CONTRIBUTING.md

+=========
+Install and Run [ansible-lint](https://github.com/willthames/ansible-lint) against your code changes.
+
+Also, Install and Run [ansible-review](https://github.com/willthames/ansible-review) against your code changes.


We may want to consider conforming to ansible-galaxy init --offline when creating roles as well.

Yup, will be sending out a mail about all the best-practices stuff soon.

kbidarkar · 2018-07-18T16:15:39Z

@omaciel, ok, filed an issue, here #5

Wanted to just get started with a role and dir_structure.

Just focused on RHEL7 OS in this PR, to begin with, the ansible-satellite6 repository.

kbidarkar · 2018-07-18T17:10:56Z

Guys, nothing is fixed in stone, this initial commit is to get started, we can evolve the project depending upon the needs moving forward.
I read stuff around ansible, looked at various ansible projects and pulled in what appeared good, also will be sending out the best practices I have found around this.

ehelms · 2018-07-18T23:47:39Z

README.md

+
+This repository will be Python3.6 based.
+
+You need Ansible installed. 


Is there a minimum Ansible version?

Currently, I am testing/working with 2.6, any suggestions as to which versions should we be supporting from? Currently, I think of from 2.5+ . Thoughts ?

Maybe I should just test with Ansible 2.5 too and set that as the min version.

This is still pending, will test and report here and then a re-review. Post which we will merge it.

ehelms · 2018-07-19T00:01:26Z

ansible.cfg

+module_utils = foreman-ansible-modules/module_utils
+roles_path = $PWD/galaxy_roles:$PWD/roles
+inventory = inventory
+retry_files_enabled = False


A few others to consider:

force_color = 1 stdout_callback = yaml display_skip_hosts = false

Ok, will take a look at each of those options and will add it up.

ehelms · 2018-07-19T00:09:15Z

ansible.cfg

+library = foreman-ansible-modules/modules
+module_utils = foreman-ansible-modules/module_utils
+roles_path = $PWD/galaxy_roles:$PWD/roles
+inventory = inventory


I'd recommend making an inventories/ directory and putting the sample in there.

I like it too, even @flatfender was suggesting the same, I just followed this from Ansible and so kept it at top-level:
https://docs.ansible.com/ansible/latest/user_guide/playbooks_best_practices.html#directory-layout

ok, I will make this as inventory_files/inventory, also would move inventory.sample file to inventory_files, else suggest me a name :)

ehelms · 2018-07-19T00:10:10Z

roles/partition-disk/handlers/main.yml

@@ -0,0 +1,2 @@
+---
+# handlers file for partition-disk


If these files are gonn abe empty, I'd just delete them to reduce the noise

In the Best-practices etherpad which I created and shared with @flatfender, I added this point to delete unused files created after we run ansible-galaxy init, but @flatfender mentioned we maintain the dir_structure as it is.

I think the idea of @flatfender was to have these as it is, for the first/initial role, so that it be an example/reference for the directory structure we want to put in place.

Maybe moving forward we can remove it, ok will discuss with @flatfender about it.

Sounds good. I tend to think the docs on roles should suffice and the code repository should have as little noise as possible.

Yes the idea was consistency around ansible-galaxy init, so that all roles have consistent structure and empty dirs don't hurt, and it makes it more galaxy friendly if we then commit back to galaxy. Once you delete them, then people tend to make things up later and we get inconsistency.

I think given that Ansible roles have a defined structure there is no worry about things getting made up. But I do feel "noise" is a valid concern. I dislike going into code bases finding empty useless files and wasting my time on them personally. That makes debugging harder IMO.

ehelms · 2018-07-19T00:10:31Z

roles/partition-disk/meta/main.yml

+  # - GPLv2
+  # - GPLv3
+  # - Apache
+  # - CC-BY


You could get rid of all these comments in here.

ehelms · 2018-07-19T00:10:46Z

roles/partition-disk/meta/main.yml

+galaxy_info:
+  author: Satellite QE Team
+  description: Satellite QE Team
+  company: RedHat


Argh! I knew about this, my bad will fix it.

ehelms · 2018-07-19T00:11:10Z

roles/partition-disk/tasks/extend_root_partition.yaml

+      fstype: xfs
+      resizefs: yes
+    with_dict: "{{ ansible_lvm.lvs }}"
+...


What are the three dots here?

I use that for YAML files to mark end of the file, as I had read about it here, https://docs.ansible.com/ansible/latest/reference_appendices/YAMLSyntax.html#yaml-basics

ehelms · 2018-07-19T00:11:29Z

roles/partition-disk/tasks/extend_root_partition.yaml

@@ -0,0 +1,16 @@
+  - name: "Extend root partition LV to all available VG space"


These should be indented at column 0

ehelms · 2018-07-19T00:12:00Z

roles/partition-disk/tasks/remove_home_partition.yaml

+      state: absent
+      force: yes
+    with_dict: "{{ ansible_lvm.lvs }}"
+...


I think these can be dropped

I use that for YAML files to mark end of the file, as I had read about it here, https://docs.ansible.com/ansible/latest/reference_appendices/YAMLSyntax.html#yaml-basics :)

I learned something new today. I have never seen that before so I might recommend not including them to reduce confusion. I do a see a mixed use of --- at the start of YAML across all YAML I have run across.

ehelms · 2018-07-19T00:12:25Z

roles/partition-disk/tasks/remove_home_partition.yaml

+    mount:
+      name: /home
+      state: absent
+  - name: "Remove /home Logical Volume"


I find it helps readability to separate tasks by an empty line just like you would a function definition in python code

*) Fixed as per yamllint *) Fixed as per ansible-review and ansible-lint *) Moved inventory file to inventory_files *) Added standards.py under rules/ansible-review. *) Updated ansible.cfg as per suggestions *) Added some best practices to CONTRIBUTING.md Signed-off-by: Kedar Bidarkar <[email protected]>

kbidarkar changed the title ~~Initial commit for Ansible based Satellite6 Install and Configure.~~ [Do Not Merge] Initial commit for Ansible based Satellite6 Install and Configure. Jul 18, 2018

kbidarkar added the Do Not Merge label Jul 18, 2018

kbidarkar force-pushed the initial-commit branch 3 times, most recently from ae88569 to 3bf95bc Compare July 18, 2018 15:01

Initial commit for Ansible based Satellite6 Install and Configure.

a9d5317

* Added a partition-disk role * Added playbooks for sat63 and sat64 Signed-off-by: Kedar Bidarkar <[email protected]>

kbidarkar force-pushed the initial-commit branch from 3bf95bc to a9d5317 Compare July 18, 2018 15:05

kbidarkar changed the title ~~[Do Not Merge] Initial commit for Ansible based Satellite6 Install and Configure.~~ Initial commit for Ansible based Satellite6 Install and Configure. Jul 18, 2018

kbidarkar removed the Do Not Merge label Jul 18, 2018

chris1984 suggested changes Jul 18, 2018

View reviewed changes

flatfender reviewed Jul 18, 2018

View reviewed changes

chris1984 approved these changes Jul 18, 2018

View reviewed changes

ehelms reviewed Jul 18, 2018

View reviewed changes

ehelms reviewed Jul 19, 2018

View reviewed changes

roles/partition-disk/meta/main.yml Outdated

# - GPLv2

# - GPLv3

# - Apache

# - CC-BY

Copy link

ehelms Jul 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could get rid of all these comments in here.

ehelms reviewed Jul 19, 2018

View reviewed changes

kbidarkar force-pushed the initial-commit branch 4 times, most recently from c9908f1 to ed6c75e Compare July 19, 2018 14:12

kbidarkar force-pushed the initial-commit branch 3 times, most recently from 68634b8 to 7d58bcc Compare July 19, 2018 14:41

kbidarkar force-pushed the initial-commit branch from 7d58bcc to 7418646 Compare July 19, 2018 18:24

chris1984 merged commit ccf9fed into SatelliteQE:master Jul 19, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial commit for Ansible based Satellite6 Install and Configure. #4

Initial commit for Ansible based Satellite6 Install and Configure. #4

kbidarkar commented Jul 18, 2018

kbidarkar commented Jul 18, 2018 •

edited

Loading

chris1984 left a comment

chris1984 Jul 18, 2018

kbidarkar Jul 18, 2018

chris1984 Jul 18, 2018

omaciel commented Jul 18, 2018

flatfender Jul 18, 2018

kbidarkar Jul 18, 2018

kbidarkar commented Jul 18, 2018

kbidarkar commented Jul 18, 2018

ehelms Jul 18, 2018

kbidarkar Jul 19, 2018

kbidarkar Jul 19, 2018

kbidarkar Jul 19, 2018

ehelms Jul 19, 2018

kbidarkar Jul 19, 2018

ehelms Jul 19, 2018

kbidarkar Jul 19, 2018

kbidarkar Jul 19, 2018

ehelms Jul 19, 2018

kbidarkar Jul 19, 2018

ehelms Jul 19, 2018

flatfender Jul 19, 2018

ehelms Jul 20, 2018

ehelms Jul 19, 2018

ehelms Jul 19, 2018

kbidarkar Jul 19, 2018

ehelms Jul 19, 2018

kbidarkar Jul 19, 2018

ehelms Jul 19, 2018

ehelms Jul 19, 2018

kbidarkar Jul 19, 2018

ehelms Jul 19, 2018

ehelms Jul 19, 2018


		This repository will be Python3.6 based.

		You need Ansible installed.

		@@ -0,0 +1,16 @@
		- name: "Extend root partition LV to all available VG space"

Initial commit for Ansible based Satellite6 Install and Configure. #4

Initial commit for Ansible based Satellite6 Install and Configure. #4

Conversation

kbidarkar commented Jul 18, 2018

kbidarkar commented Jul 18, 2018 • edited Loading

chris1984 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

omaciel commented Jul 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kbidarkar commented Jul 18, 2018

kbidarkar commented Jul 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kbidarkar commented Jul 18, 2018 •

edited

Loading