Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.15.z] hosts table: Name locator fix (again) #1638

Merged

Conversation

Satellite-QE
Copy link
Contributor

Cherrypick of PR: #1603

Problem Statement

Re-introducing this fix after being reverted.
This commit unintentionally broke navigation to host details page,
which was caused by another issue in the Sat hosts table
and fixed in #1465

Description:

The HostsView Name table column XPath was missing leading '.' character,
which caused that all host rows that were returned, had the same Name value,
equal to the first table row host Name.

Re-introducing this fix after being reverted.
This commit unintentionally broke navigation to host details page,
which was caused by another issue in the Sat hosts table,
then fixed in 71a745e

Original description:

The `HostsView` Name table column XPath was missing leading '.' character,
which caused that all host rows returned had the same Name value,
equal to the first table row host Name.

(cherry picked from commit 7d85389)
@Satellite-QE Satellite-QE added 6.15.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR No-CherryPick PR doesnt need CherryPick to previous branches labels Nov 20, 2024
@Satellite-QE
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py tests/foreman/longrun/test_oscap.py::test_positive_oscap_remediation tests/foreman/ui/test_host.py::test_positive_host_details_read_templates

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing label Nov 20, 2024
@pondrejk
Copy link
Contributor

not sure what's up with airgun-prt, but I reckon the test result in SatelliteQE/robottelo#16965 proved it works

@pondrejk pondrejk merged commit 19b576d into 6.15.z Nov 21, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants