Implement Malice Force Upgrade #3517
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I saw some cards that were currently not implemented and wanted to contribute if possible.
This PR is an implementation for Malice, based on the pattern used by some other force mod abilities (d-vader/boy-vader) and other crit dealing abilities (Kylo, Maarek etc). I wasn't aware of another ability that has you checking whether or not you spent a force when dealing a crit, so I chose to store that as a local variable, update it when the force is spent, and then reset it at the end of the attack (L34, L61, L92), but if there's a better approach I would be happy to use that.
I've tested this locally in hotseat games and seems to work as best as I can tell, but I'm not sure if there's any more comprehensive way to test things.
If there's another branch or some other way you'd like me to make this PR let me know!