Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): failure in PyCharm on Ubuntu 22 #730

Merged
merged 1 commit into from
Aug 19, 2022
Merged

fix(test): failure in PyCharm on Ubuntu 22 #730

merged 1 commit into from
Aug 19, 2022
+5 −0

Conversation

i-keliukh
Copy link
Contributor

The failure is caused by colorama package producing excessive output at the process
termination. The additional output leads to error when parsing json.

Details:

  1. 'isort -' adds a (colored?) character at the end of the pipe when the test is launched from PyCharm PyCQA/isort#1657
  2. Tools with colorama cannot be automated within Pycharm tartley/colorama#307

@i-keliukh
fix(test): failure in PyCharm on Ubuntu 22
0559032 
The failure is caused by colorama package producing excessive output at the process
termination. The additional output leads to error when parsing json.

Details:
1. PyCQA/isort#1657
2. tartley/colorama#307
@i-keliukh i-keliukh requested a review from k-dovgan August 19, 2022 07:54
@i-keliukh i-keliukh merged commit 5b1936d into master Aug 19, 2022
@i-keliukh i-keliukh deleted the colorama-workaround branch August 19, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-dovgan k-dovgan k-dovgan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i-keliukh @k-dovgan