Skip to content

[NUI] Do not make to hold Delegate as NativeHolder#7498

Merged
hinohie merged 1 commit intoSamsung:DevelNUIfrom
hinohie:remove_delegate_holder
Mar 1, 2026
Merged

[NUI] Do not make to hold Delegate as NativeHolder#7498
hinohie merged 1 commit intoSamsung:DevelNUIfrom
hinohie:remove_delegate_holder

Conversation

@hinohie
Copy link
Contributor

@hinohie hinohie commented Feb 27, 2026

Revert patch of #7485.

Since Delegate have strong dependency with object, View never be GC if we call AddToNativeHolder();

Until found solution, block the code temprary.

Description of Change

API Changes

  • ACR:

Revert patch of Samsung#7485.

Since Delegate have strong dependency with object, View never be GC if we call AddToNativeHolder();

Until found solution, block the code temprary.

Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Copy link
Contributor

@everLEEst everLEEst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@hinohie hinohie merged commit 95f5825 into Samsung:DevelNUI Mar 1, 2026
4 checks passed
@hinohie hinohie deleted the remove_delegate_holder branch March 1, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants