Skip to content

[NUI][API13] Do not make to hold Delegate as NativeHolder #7497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hinohie merged 1 commit into from
Feb 27, 2026
Merged

[NUI][API13] Do not make to hold Delegate as NativeHolder #7497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/Tizen.NUI/src/public/BaseComponents/ViewInternal.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1703,14 +1703,18 @@ private void InternalClearBackground()

internal void CreateSafeCallback<T>(T method, out T safeCallback) where T : Delegate
{
AddToNativeHolder(method);
// TODO : Delgate strong-connected with object. So if we hold method, View could not be GC.
// But we have to keep safeCallback since Native could invoke it if View & Delegate GC.
// Until find good way to resolve this issue,

// AddToNativeHolder(method);
safeCallback = method;
}

internal void ReleaseSafeCallback<T>(ref T safeCallback) where T : Delegate
{
Debug.Assert(safeCallback != null);
RemoveFromNativeHolder(safeCallback);
// RemoveFromNativeHolder(safeCallback);
safeCallback = null;
}
}
Expand Down
8 changes: 6 additions & 2 deletions src/Tizen.NUI/src/public/Common/Layer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,14 +989,18 @@ internal class Property

internal void CreateSafeCallback<T>(T method, out T safeCallback) where T : Delegate
{
AddToNativeHolder(method);
// TODO : Delgate strong-connected with object. So if we hold method, View could not be GC.
// But we have to keep safeCallback since Native could invoke it if View & Delegate GC.
// Until find good way to resolve this issue,

// AddToNativeHolder(method);
safeCallback = method;
}

internal void ReleaseSafeCallback<T>(ref T safeCallback) where T : Delegate
{
Debug.Assert(safeCallback != null);
RemoveFromNativeHolder(safeCallback);
// RemoveFromNativeHolder(safeCallback);
safeCallback = null;
}

Expand Down
Loading