Skip to content

Conversation

@babenek
Copy link
Contributor

@babenek babenek commented May 18, 2025

Description

Please include a summary of the change and which is fixed.

  • Add Java .class file deep scanner for constants which are Utf8 strings
  • Improved PKCS scanner for PKCS#1, PKCS#8 and PKCS#12 keys
  • refactored PEM private key detection

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2025

Codecov Report

Attention: Patch coverage is 87.11656% with 21 lines in your changes missing coverage. Please review.

Project coverage is 92.68%. Comparing base (8579630) to head (a56f20f).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
credsweeper/deep_scanner/jclass_scanner.py 85.18% 5 Missing and 3 partials ⚠️
credsweeper/deep_scanner/pkcs_scanner.py 72.00% 5 Missing and 2 partials ⚠️
credsweeper/utils/util.py 95.16% 1 Missing and 2 partials ⚠️
credsweeper/deep_scanner/deep_scanner.py 85.71% 0 Missing and 2 partials ⚠️
credsweeper/filters/value_base64_key_check.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #716      +/-   ##
==========================================
- Coverage   92.80%   92.68%   -0.12%     
==========================================
  Files         141      142       +1     
  Lines        5127     5222      +95     
  Branches      841      855      +14     
==========================================
+ Hits         4758     4840      +82     
- Misses        228      235       +7     
- Partials      141      147       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@babenek babenek marked this pull request as ready for review May 18, 2025 19:47
@babenek babenek requested a review from a team as a code owner May 18, 2025 19:47
@babenek babenek marked this pull request as draft May 19, 2025 05:54
@babenek babenek marked this pull request as ready for review May 19, 2025 14:56
@babenek babenek marked this pull request as draft May 19, 2025 14:56
@babenek babenek marked this pull request as ready for review May 19, 2025 17:25
@babenek babenek merged commit a8c06d7 into Samsung:main May 20, 2025
44 of 45 checks passed
@babenek babenek deleted the pkcs branch May 20, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants