Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compose based deployment docs #4

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

i-am-yuvi
Copy link

No description provided.

@vercel
Copy link

vercel bot commented Sep 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rcw-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 10:12pm

@@ -0,0 +1,117 @@
---
title: Composed Based Deployment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is "compose" based, not "composed" based.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

@tushar5526
Copy link

Also, it seems that you have added images for configuring Jenkins in compose-based deployment. This should rather go in swarm-based deployment.

Compose based deployment will only have steps that we discussed yesterday on discord.

@i-am-yuvi i-am-yuvi requested a review from tushar5526 September 4, 2023 08:14
@i-am-yuvi
Copy link
Author

Also, it seems that you have added images for configuring Jenkins in compose-based deployment. This should rather go in swarm-based deployment.

Compose based deployment will only have steps that we discussed yesterday on discord.

I have just added the images for storing the registry_server address that we need to configure here too ri8?

@tushar5526
Copy link

@i-am-yuvi Please resolve the conflicts


Here we'll deploy our pipeline in the Docker Container using compose.

## Pre-requisites:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These pre-requisites are wrong. we only need docker-compose, docker and make for this. Not jenkins vault etc.

- Make cli for running Makefile

## Setting up the Pipeline
- ### **Clone the repository**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove every instruction associated with vault, jenkins etc. We don't need to install them.

docker compose up -d
```

![Docker Compose image](../assets/docker_compose_up.png)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only this step is needed after the pre-requisites are met.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

Copy link

@tushar5526 tushar5526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jenkis, Vault etc. are needed for compose based deployment.

@i-am-yuvi
Copy link
Author

I have updated the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants