fix(tabs): include role:presentation to ensure tabs are grouped #7699
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomdavies73
previously approved these changes
Jan 12, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes an accessibility issue where screen readers were announcing tabs incorrectly as "1 of 1" instead of properly grouping them. The fix adds the role="presentation" attribute to ensure proper tab grouping semantics for assistive technologies.
Changes:
- Added
role="presentation"to theStyledTabProvidercomponent to improve screen reader announcements - Updated the Storybook decorator background color to align with the Design System
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/tabs/next/tab.context.tsx | Added role="presentation" attribute to fix screen reader tab grouping |
| src/components/tabs/next/tabs.stories.tsx | Updated background color in Storybook decorator to match Design System standards |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
edleeks87
previously approved these changes
Jan 12, 2026
nineteen88
changed the title
nineteen88
dismissed stale reviews from edleeks87 and tomdavies73
via
a475fd0
paulrobinson88
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Current behaviour
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions