Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYNPY-1544] Fixes docstring #1155

Merged
merged 3 commits into from
Jan 28, 2025
Merged

[SYNPY-1544] Fixes docstring #1155

merged 3 commits into from
Jan 28, 2025

Conversation

BWMac
Copy link
Contributor

@BWMac BWMac commented Jan 28, 2025

This small PR updates an example docstring for the required access level to add annotations to a Synapse entity with a Synapse Agent prompt.

@BWMac BWMac requested a review from a team as a code owner January 28, 2025 20:10
@BWMac BWMac requested a review from BryanFauble January 28, 2025 20:11
@BryanFauble
Copy link
Contributor

An update on the sync protocol will also be needed

https://github.com/Sage-Bionetworks/synapsePythonClient/blob/develop/synapseclient/models/protocols/agent_protocol.py

@BWMac BWMac requested a review from BryanFauble January 28, 2025 20:22
Copy link
Contributor

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We don't need to wait for the build on this one

@BWMac BWMac merged commit d085b02 into develop Jan 28, 2025
12 of 18 checks passed
@BWMac BWMac deleted the bwmac/docstring-patch branch January 28, 2025 20:33
BWMac added a commit that referenced this pull request Feb 3, 2025
* [SYNPY-1544] Synapse Agent OOP Model (#1152)

* Adds async convenience functions

* expose convenience functions

* updates convenience functions

* updates agent_services

* removes rest_get_async exception handling

* pre-commit fixes

* delete accidentally committed script

* adds initial agent implementation

* clean up agent

* adds missing docstrings

* pre-commit

* updates agent_services

* updates agent.py

* Updates alias ID handling

* adds syncronous interface

* prevent cicular import in storable_entity_components

* remove promt sending and receiving from agent_service

* adds initial (dirty) async job mixin

* pre-commit run

* [SYNPY-1544] potential changes to mixin (#1153)

* Changes for async mixin

* Remove arg

* bug fix

* generalizes send_job_and_wait_async

* removes typing.Self

---------

Co-authored-by: bwmac <bwm03570@gmail.com>

* cleans up agent logic

* adds async job unit tests

* updates async job tests

* adds agent unit tests

* adds integration tests

* pre-commit

* adds examples to agent.py

* removes todos

* adds POC script

* add to mixins

* adds agent docs

* updates agent docs

* reorganize documentation

* updates poc script

* clean up

* add docstring

* removes unused imports

* split too long lines

* force synapse_client kwarg

* updates agent.py

* updates synapse_client docstring description

* updates asynchronous_job

* updates integration tests

* pre-commit

* agent inherited members

* updates docs for inherited members

* missing inherited members

* updates doc formatting

* try team formatting change

* updates script description

* adds Annotation lazy import

* try team formatting change

* more formatting changes

* address review comments in agent.py

* move synchronous docs up a layer

* adds syn login

* adds warning message to docs

* updates docstring examples

* updates docstrings

* adds error handling for agent.get

* async integration tests

* fix conditional

* disables integration tests

* updates docstring for clarity

---------

Co-authored-by: BryanFauble <17128019+BryanFauble@users.noreply.github.com>

* [SYNPY-1544] Fixes docstring (#1155)

* fixes docstring

* protocol docstring

* fix imports

* Removes example setting annotations with Agent class (#1156)

* removes annotation example

* pre-commit

* [SYNPY-1557] Sync a Linked Folder Bug (#1157)

* fixes docstring

* protocol docstring

* fix imports

* adds integration test for expected behavior

* adds fix

* merge weirdness

* fix test docstring

* [SYNPY-1544] Return the AgentPrompt when calling the prompt function (#1158)

* update version v4.7.0

* version v4.7.0 docs

* pre-commit

---------

Co-authored-by: BryanFauble <17128019+BryanFauble@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants