[SYNPY-1544] potential changes to mixin

[BryanFauble]

@BWMac and I are working together to discuss ways in which we will implement this feature

[pep8speaks]

Hello @BryanFauble! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file synapseclient/models/mixins/asynchronous_job.py:

Line 23:89: E501 line too long (109 > 88 characters)
Line 34:89: E501 line too long (108 > 88 characters)
Line 50:89: E501 line too long (108 > 88 characters)
Line 67:89: E501 line too long (108 > 88 characters)
Line 240:89: E501 line too long (140 > 88 characters)
Line 277:89: E501 line too long (140 > 88 characters)
Line 309:89: E501 line too long (96 > 88 characters)

Comment last updated at 2025-01-14 20:51:40 UTC

[BWMac]

Thank you, this is much better than what I had previously. I like using AgentPrompt as the async communicator, makes much more sense.

[BWMac]

should these be in a separate script?

[BryanFauble]

Good point. This would probably make sense to live within a py script at synapseclient.api

[BWMac]

I can do this before merging

[BWMac]

@BryanFauble Actually, maybe that isn't possible. If we move get_job_async we need to move the AsynchronousJobStatus and AsynchronousJobState classes to avoid a circular import issue, but that doesn't make a whole lot of sense to me to have those classes in a _services.py script. I think I will leave these where they are for now.

[BWMac]

Thank you, this is much better than what I had previously. I like using AgentPrompt as the async communicator, makes much more sense.