Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sage-monorepo): pass GHCR credentials to the dev container in the release workflow #2876

Merged
merged 1 commit into from
Oct 4, 2024
Merged

fix(sage-monorepo): pass GHCR credentials to the dev container in the release workflow #2876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
run: |
# Extract the product name (part before the first slash) and version (part after the first slash)
PRODUCT=$(echo "${GITHUB_REF#refs/tags/}" | cut -d'/' -f1)
VERSION=$(echo "${GITHUB_REF#refs/tags/}" | cut -d'/' -f2)
VERSION=$(echo "${GITHUB_REF#refs/tags/}" | cut -d'/v' -f2)

# Output extracted values for the rest of the job
echo "PRODUCT=${PRODUCT}" >> $GITHUB_ENV
Expand All @@ -40,5 +40,6 @@ jobs:
- name: Build the images of all the OC projects
run: |
devcontainer exec --workspace-folder ../sage-monorepo bash -c ". ./dev-env.sh \
&& echo $DOCKER_PASSWORD | docker login --username $DOCKER_USERNAME --password-stdin ghcr.io \
&& export VERSION=${{ env.VERSION }} \
&& nx build-image ${{ env.PRODUCT }}-apex --configuration=ci"
19 changes: 9 additions & 10 deletions apps/openchallenges/apex/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,20 @@
"build-image": {
"executor": "@nx-tools/nx-container:build",
"options": {
"context": "{projectRoot}",
"metadata": {
"images": ["ghcr.io/sage-bionetworks/{projectName}"]
},
"push": false
"context": "{projectRoot}"
},
"configurations": {
"local": {
"tags": ["type=edge,branch=main", "type=raw,value=local", "type=sha"]
"metadata": {
"images": ["ghcr.io/sage-bionetworks/{projectName}"],
"tags": ["type=edge,branch=main", "type=raw,value=local", "type=sha"]
}
},
"ci": {
"cache-from": ["type=gha"],
"cache-to": ["type=gha,mode=max"],
"push": true,
"tags": ["type=semver,pattern={{version}},value=${VERSION}", "type=sha"]
"metadata": {
"images": ["ghcr.io/sage-bionetworks/{projectName}"],
"tags": ["type=raw,value=${VERSION}", "type=sha"]
}
}
},
"defaultConfiguration": "local"
Expand Down
Loading