feat(agora): create the project agora-app-tailwind (ARCH-298)
#2865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors when importing all the app routes defined in
|
sagely1
reviewed
Oct 1, 2024
Comment on lines
57
to
+60
| echo "There are no processes listening to the port $port." | ||
| else | ||
| echo "Killing the processes listening to the port $port." | ||
| kill $pids | ||
| kill -9 $pids |
There was a problem hiding this comment.
As a suggestion, we could try killing normally and then force killing if the port is still in use.
function workspace-kill-port {
local port="$1"
# Check if the port exists
if ! lsof -i :$port > /dev/null; then
echo "Port $port is not open."
return
fi
# Get PIDs of processes listening on the port
local pids=$(lsof -t -i:$port)
if [ -z "$pids" ]; then
echo "No processes found listening on port $port."
return
fi
echo "Attempting to kill processes listening on port $port..."
# First, try a regular kill
kill $pids
# If the above fails, use kill -9
if ! kill -0 $pids > /dev/null 2>&1; then
echo "Failed to kill processes. Using SIGKILL"
kill -9 $pids
fi
# Verify if the processes were killed successfully
if ! ps -p $pids > /dev/null; then
echo "Processes listening on port $port have been successfully terminated."
else
echo "Warning: Processes listening on port $port were not terminated successfully."
fi
}
sagely1
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to https://sagebionetworks.jira.com/browse/ARCH-298
Changelog
agora-app-tailwindwith esbuild and Tailwind enabledworkspace-kill-port <port>to effectively kill the Angular app started withserveImportant
I wanted this PR to supporting the linting with files with Tailwind ESLint plugin. Ideally, the configuration would be applied in the root ESLint config file. However, we may want to only lint specific files and projects that we know use Tailwind because there are many JS, TS and HTML files that do not include any Tailwind class name, which triggers this error:
tailwindcss/no-custom-classname. Configuring ESLint to enforce Tailwind rules will be handled in a separate PR.Initially included but then removed:
Notes
Stylelint
It looks like the VS Code extension for Stylelint does not automatically take into account changes made to the Stylelint config file (
stylelint.config.mjs). One solution that works is to restart VS Code. Another option may be to disable and re-enable the extension (not tested).Angular apps built with esbuild and started with
nx servemay still be running after Ctrl + CThis behavior was previously observed with
sandbox-angular-app. This issue does not affect apps built with Webpack.There is an issue with the command
nx serve agora-app-tailwindwhere stopping the command with Ctrl + C won't stop the process. Yet the app will no longer be available onlocalhost:4200. The process that is still running can be seen in the list of ports forwarded in VS Code or with the command:As result, trying to serve the app again will lead to the issue shown below:
Observations:
kill -9 <pid>but not withkill <pid>as done byworkspace-kill-port <port>. Hence, this PR update the command to runkill -9 <pid>.Warning
Changes made to
dev-env.sh, where the commandworkspace-kill-portis defined, require to source this Bash file again. This can be achieved with the command. ./dev-env.shor simply opening a new terminal that automatically source this file.Preview
Create the app
Serve the app