Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openchallenges): patch the entry point script of Thumbor to replace 'None' by None (IT-3908) #2856

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix(openchallenges): patch the entry point script of Thumbor to replace 'None' by None (IT-3908) #2856

merged 1 commit into from
Sep 25, 2024

Conversation

tschaffter
Copy link
Member

@tschaffter tschaffter commented Sep 25, 2024 •
edited
Loading

Fixes https://sagebionetworks.jira.com/browse/IT-3908

Description

This PR implements a temporary fix to the issue reported in beeyev/thumbor-s3-docker#35.

Preview

From inside the container, we can now successfully fetch images.

/app # wget http://localhost:8889/unsafe/600x600/triforce.png
Connecting to localhost:8889 (127.0.0.1:8889)
saving to 'triforce.png'
triforce.png         100% |******************************************************************************************************************************************************************************|  379k  0:00:00 ETA
'triforce.png' saved

@tschaffter tschaffter self-assigned this Sep 25, 2024
@tschaffter tschaffter marked this pull request as ready for review September 25, 2024 21:30
@tschaffter tschaffter merged commit d86d727 into Sage-Bionetworks:main Sep 25, 2024
9 of 10 checks passed
@tschaffter tschaffter deleted the openchallenges/fix-thumbor-none branch September 25, 2024 21:30
@tschaffter tschaffter changed the title fix(openchallenges): patch the entry point script of Thumbor to replace 'None' by None fix(openchallenges): patch the entry point script of Thumbor to replace 'None' by None (IT-3908) Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrchai rrchai Awaiting requested review from rrchai rrchai is a code owner

@vpchung vpchung Awaiting requested review from vpchung

Assignees

@tschaffter tschaffter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tschaffter