Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openchallenges): fix button on home page #2318

Merged
merged 3 commits into from
Nov 4, 2023
Merged

fix(openchallenges): fix button on home page #2318

merged 3 commits into from
Nov 4, 2023

Conversation

vpchung
Copy link
Member

@vpchung vpchung commented Nov 3, 2023

Fixes #2311

Changelog

  • set button text color to white
  • add uppercase transformation
  • formatting cleanup

Preview

This will update the section to match what is currently in production:
Screenshot 2023-11-03 at 1 21 20 PM

@vpchung vpchung marked this pull request as ready for review November 4, 2023 02:44
tschaffter
tschaffter approved these changes Nov 4, 2023
View reviewed changes
Copy link
Member

@tschaffter tschaffter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vpchung vpchung merged commit b00d56e into Sage-Bionetworks:main Nov 4, 2023
6 checks passed
@vpchung vpchung deleted the bug-2311 branch November 4, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tschaffter tschaffter tschaffter approved these changes

@rrchai rrchai Awaiting requested review from rrchai rrchai is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Add a Challenge button should have a white label
2 participants
@vpchung @tschaffter