Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(openchallenges): improve the quality of the team members' avatars #2312

Merged
merged 8 commits into from
Nov 4, 2023
Merged

feat(openchallenges): improve the quality of the team members' avatars #2312

merged 8 commits into from
Nov 4, 2023

Conversation

rrchai
Copy link
Contributor

@rrchai rrchai commented Nov 2, 2023 •
edited by tschaffter
Loading

Changelog

  • Set QUALITY to 100 in Thumbor
  • Upload higher-res, more professional images of the team members
  • Refactor slightly the code

Important
The QUALITY setting in .env.example has been modified. Ensure you update the .env for Thumbor and rebuild the Thumbor image to reflect these changes.

Preview

image

@rrchai rrchai self-assigned this Nov 2, 2023
@rrchai rrchai marked this pull request as ready for review November 2, 2023 23:54
@rrchai rrchai requested a review from mdsage1 November 2, 2023 23:54
tschaffter
tschaffter requested changes Nov 3, 2023
View reviewed changes
libs/openchallenges/team/src/lib/team.component.ts Outdated Show resolved Hide resolved
libs/openchallenges/team/src/lib/team.component.ts Outdated Show resolved Hide resolved
libs/openchallenges/team/src/lib/team.component.ts Outdated Show resolved Hide resolved
libs/openchallenges/team/src/lib/team.component.ts Outdated Show resolved Hide resolved
libs/openchallenges/team/src/lib/team.component.ts Outdated Show resolved Hide resolved
@tschaffter tschaffter self-requested a review November 3, 2023 20:09
@tschaffter tschaffter self-assigned this Nov 3, 2023
@tschaffter tschaffter merged commit 983b8af into Sage-Bionetworks:main Nov 4, 2023
6 checks passed
@rrchai rrchai deleted the improve-team-avatar branch January 10, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tschaffter tschaffter tschaffter approved these changes

@vpchung vpchung Awaiting requested review from vpchung

@mdsage1 mdsage1 Awaiting requested review from mdsage1

Assignees

@tschaffter tschaffter

@rrchai rrchai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Improve the quality of the team members' pictures ⭐
2 participants
@rrchai @tschaffter