SWC-6624: fixes #5246
Merged
SWC-6624: fixes #5246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g e2e tests, ensure that e2e report is pushed to s3 even if playwright tests fail
hallieswan
commented
Dec 13, 2023
Comment on lines
+66
to
+71
| - name: Confirm build downloaded | ||
| run: | | ||
| if [ ! -f "/$(pwd)/${{ env.BUILD_DIR }}/${{ env.BUILD_NAME }}" ]; then | ||
| echo "::error ::downloaded WAR not found" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
The latest e2e run on this branch did not repro the failures on develop, where the Playwright tests failed to run with this error: TypeError: The argument 'file' cannot be empty. Received ''. However, I can repro the error locally by deleting the SWC WAR, so that the file doesn't exist at the volume path specified when launching the SWC tomcat container.
Add this check to confirm that the build was successfully downloaded to help with troubleshooting if the same error occurs on develop in the future.
hallieswan
commented
Dec 13, 2023
| @@ -85,15 +91,15 @@ jobs: | |||
| TRACE_TOGGLE: ${{ github.repository_owner == 'Sage-Bionetworks' && 'on' || 'off'}} | |||
| run: yarn playwright test --shard ${{ matrix.shard }} --trace=${{ env.TRACE_TOGGLE }} | |||
| - name: Assume AWS Role | |||
| if: github.repository_owner == 'Sage-Bionetworks' | |||
| if: ${{ github.repository_owner == 'Sage-Bionetworks' && always() }} | |||
There was a problem hiding this comment.
When running in the Sage repo, ensure that e2e report is pushed to S3 even if Playwright tests fail
nickgros
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.