Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tspan fix #1006

Merged
merged 2 commits into from
Nov 10, 2024
Merged

Tspan fix #1006

merged 2 commits into from
Nov 10, 2024

Conversation

jfhenon
Copy link
Collaborator

@jfhenon jfhenon commented Nov 10, 2024

PR description

Checklist

Note that we require UI tests to ensure that the added feature will not be
nixed by some future fix and that there is at least some test-as-documentation
to indicate how the fix or enhancement is expected to behave.

  • - Added Cypress UI tests
  • - Ran npm test, ensuring linting passes and that Cypress UI tests keep
    coverage to at least the same percent (reflected in the coverage badge
    that should be updated after the tests run)
  • - Added any user documentation. Though not required, this can be a big
    help both for future users and for the PR reviewer.

@jfhenon
Copy link
Collaborator Author

jfhenon commented Nov 10, 2024

fix #958

@jfhenon jfhenon merged commit f0549e4 into master Nov 10, 2024
6 checks passed
@jfhenon jfhenon deleted the tspan-fix branch November 10, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant