-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unuse parameters for uyuni and 5.0 BV pipelines #1425
Remove unuse parameters for uyuni and 5.0 BV pipelines #1425
Conversation
Actually... we might want to keep server_configuration in build_host, depending of what we decide about autoconnect feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's resolve what we do with uyuni-project/sumaform#1736 first
Removing |
Indeed, if we keep it on false in these envs, we dont't need to provide any server config 👍 |
What does this PR ?
Remove all parameters not use during deployment. Either it's not used during the salt states ( example server_configuration without auto connect to master ) or default value is true ( venv-salt-bundle install ).
The idea is to simplify our BV description and later create a common template.
Depends on: uyuni-project/sumaform#1736.
I didn't impact 4.3 for stability.