do not insert NULL for former_identifier and product_type #151
+12
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is product_type being not set a valid product definition? |
|
Yes, the error is caused by a NULL product type definition. I am not familiar with the process, but I guess the product type is not a required option when enabling a new product in SCC. From smt's perspective I think this patch is an enhancement for such case. |
|
Could you please add a note to the changelog? |
|
The changelog has been updated. |
|
I cannot see a change in the changelog (https://github.com/SUSE/smt/blob/SMT12/package/smt.changes). Could you please add a short note there? |
This patch is supposed to fix the following error when running `smt-sync refresh` command > 12sp5:~ # smt-sync refresh > Downloading Product and Repository information > Download (100%) > DBD::mysql::db do failed: Column 'PRODUCT_TYPE' cannot be null at /usr/lib/perl5/vendor_perl/5.18.2/SMT/SCCSync.pm line 892. > DBD::mysql::db do failed: Column 'PRODUCT_TYPE' cannot be null at /usr/lib/perl5/vendor_perl/5.18.2/SMT/SCCSync.pm line 892. References: bsc#1239441
|
Sorry for misunderstanding. I have added an entry there. |
digitaltom
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following error messages are reported when running smt-sync command
References: bsc#1239441