Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify auth header check #1298

Merged
merged 3 commits into from
Mar 24, 2025
Merged

Simplify auth header check #1298

merged 3 commits into from
Mar 24, 2025

Conversation

jesusbv
Copy link
Collaborator

@jesusbv jesusbv commented Mar 13, 2025

Description

Move auth check to outer method
from SccProxy.get_scc_activations -> SccProxy.scc_check_subscription_expiration

SccProxy.get_scc_activations method now accepts auth and not the full headers object

  • Related Issue / Ticket / Trello card:

How to test

All operations should remain the same and keep the same behaviour

Change Type

Please select the correct option.

  • Bug Fix (a non-breaking change which fixes an issue)
  • New Feature (a non-breaking change which adds new functionality)
  • Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

  • I have reviewed my own code and believe that it's ready for an external review.
  • I have provided comments for any hard-to-understand code.
  • I have documented the MANUAL.md file with any changes to the user experience.
  • If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Review

Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.

Sorry, something went wrong.

Move auth check to outer method
from SccProxy.get_scc_activations -> SccProxy.scc_check_subscription_expiration

SccProxy.get_scc_activations now accepts auth and not the full headers object
@jesusbv jesusbv requested review from digitaltom and rjschwei March 13, 2025 13:52
@jesusbv jesusbv self-assigned this Mar 13, 2025
@jesusbv jesusbv added the 2.22 label Mar 13, 2025
@jesusbv jesusbv changed the title Simply auth header check Simplify auth header check Mar 13, 2025
@jesusbv jesusbv merged commit ec7bb7f into master Mar 24, 2025
3 checks passed
@jesusbv jesusbv deleted the simplify-check branch March 24, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants