Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the columns of System table #1292

Merged
merged 5 commits into from
Mar 24, 2025
Merged

Check the columns of System table #1292

merged 5 commits into from
Mar 24, 2025

Conversation

jesusbv
Copy link
Collaborator

@jesusbv jesusbv commented Mar 5, 2025

Description

In order for the data export engine to be able to send the information we rely on the System table to have the proper structure and fields

If those fields change, we can not send the information to the DW

  • Related Issue / Ticket / Trello card:

How to test

Change the System table columns/model and run the tests

Change Type

Please select the correct option.

  • Bug Fix (a non-breaking change which fixes an issue)
  • New Feature (a non-breaking change which adds new functionality)
  • Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

  • I have reviewed my own code and believe that it's ready for an external review.
  • I have provided comments for any hard-to-understand code.
  • I have documented the MANUAL.md file with any changes to the user experience.
  • If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Review

Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.

In order for the data export engine to be able to send the information
we rely on the System table to have the proper structure and fields

If those fields change, we can not send the information to the DW
@jesusbv jesusbv self-assigned this Mar 5, 2025
@digitaltom
Copy link
Member

The reason you described for this in the pr description need to go into the description of the test, including a guideline what to do when the structure changes.
Else on the next db structure change somebody just adapts the test.

@jesusbv
Copy link
Collaborator Author

jesusbv commented Mar 12, 2025

The reason you described for this in the pr description need to go into the description of the test, including a guideline what to do when the structure changes. Else on the next db structure change somebody just adapts the test.

Done

@jesusbv jesusbv added the 2.22 label Mar 12, 2025
@jesusbv jesusbv merged commit c6327d2 into master Mar 24, 2025
3 checks passed
@jesusbv jesusbv deleted the check-db-datewarehouse branch March 24, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants