-
Notifications
You must be signed in to change notification settings - Fork 18
Improve SELinux article for SLE16 #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@ca-hu when it is ready for review , please tag me, thanks :) |
@Amrita42 it is ready for review :) I did not do spellchecking or grammar checks, could you do them according to your doc team guidelines and add it as commit on top? I assume you want to pick and choose or rewrite stuff I did according to doc team guideline anyway, so I think the easiest would be if you do the rest. Also I think it would be good if selinux-tools section would be a different article. Also feel free to split the article if you think it is too long. I would hand this over to you now :) |
also let me know when you are done, then i can ask someone from the selinux team to do a quick proofread again :) thanks! |
sorry, i found two additional things, done now |
We don't want to have the SELINUX=disabled option in the /etc/selinux/config documented, since it is a dirty hack and mixing enforcing/permissive and enabling/disabling can cause issues during boot due to systemd being confused (see bsc#1239717) Therefor dropping SELINUX=disabled and adding a seperate section for how to disable SELinux and re-enable it
Also reorder chapters into subchapters
- Add concept for selinux-policy-targeted - Fix wording and add explanations in concepts/selinux-policy.md - Restructure SLE 16 policy overview part in SELinux article
To include examples and Tips
add a more clear example
Make wording more clear
Make wording more clear
The existing ordering is not intuitive, reorder with top down with most used
Add more context regarding the concepts of booleans
... for administration and development
It did not look complete and it needed more explanation
Add description how to use SELinux ports with example on how to change the SSH daemon port to port 2222
also move things around
@ca-hu thanks for the extensive review and additions . Lets keep tools within the article , its fine as is. You can now handover to someone from your team for a final check. Noe that , post that I will request Daria to review (she does the final style and grammar review in our team) |
thanks, will do :) |
- Move troubleshooting section up - Fix some formulation and typos
i added some changes from the final check, otherwise looks good changes: basically some typo fixes and i moved the troubleshooting section back up, because it is super important as it is very tricky to do. if you do not like the changes, you can just revert it with: otherwise looks good from my side, can be merged :) |
Description
Improve SELinux article for SLE 16. Please check thourougly since I am not in the docs team and don't really know all the guidelines
DONE:
Are there any relevant issues/feature requests?
Is this (based on) existing content?
yes