Temporarily skip startup test on ppc64le #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcermak
reviewed
Nov 12, 2024
tests/test_init.py
Outdated
| @@ -44,6 +44,10 @@ def test_systemd_no_udev_present(self, auto_container): | |||
| def test_systemd_boottime(self, auto_container): | |||
| """Ensure the container startup time is below 5 seconds""" | |||
|
|
|||
| # Temporary workaround: While using emulated workers, the startup time test doesn't make sense.' | |||
| if auto_container.connection.system_info.arch == "ppc64le": | |||
| return | |||
There was a problem hiding this comment.
Please use pytest.skip() with a reason why here
Also, please add a giant FIXME somewhere
There was a problem hiding this comment.
Can this FIXME have an issue so we dont forget about it?
dcermak
reviewed
Nov 12, 2024
Due to worker unavailability we need to run ppc64le on emulated workers at the moment where the startup times are always larger than the threshold. Therefore there is no point in running this test at all on ppc64le at the moment.
dirkmueller
previously approved these changes
Nov 12, 2024
dirkmueller
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to worker unavailability we need to run ppc64le on emulated workers at the moment where the startup times are always larger than the threshold. Therefore there is no point in running this test at all on ppc64le at the moment.
[CI:TOXENVS] init