shfmt & shellcheck - take 2 #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial commit of `shfmt` and `shellcheck`. More to come.
This reverts commit 20e36b6.
Closed
Without escape the shell will expand it when perl does it replacement.
Also this setup havn't worked for some time (years? dists?): ``` [ 3.082391] systemd-rc-local-generator[269]: /etc/rc.local is not marked executable, skipping. ```
And since we now use arrays in bash all the POSIX compatility is under the bus.
Damn you smart editor
|
Author
|
Ok so!
|
eest
approved these changes
Dec 2, 2025
eest
left a comment
eest
left a comment
There was a problem hiding this comment.
Tested in cdn-ops, did not see any problems on debian 13.
LGTM
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.