Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove package-lock.json in favor of yarn #36

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Remove package-lock.json in favor of yarn #36

merged 2 commits into from
Feb 28, 2024

Conversation

sherakama
Copy link
Member

@sherakama sherakama commented Jan 30, 2024 •
edited
Loading

READY FOR REVIEW

Summary

  • Remove package-lock.json file in favor of yarn and the gitpod integration.

Review By (Date)

  • Feb 28

Criticality

  • Low

Urgency

  • None

Review Tasks

  1. Think about the change and your work. Leave comments.

@sherakama
Delete package-lock.json
a31485a 
Remove package-lock.json file in favor of yarn and the gitpod integration.
@sherakama
Update README.md
b134396 
Remove npm documentation
@sherakama sherakama changed the title Delete package-lock.json Remove package-lock.json in favor of yarn Jan 30, 2024
jdwjdwjdw
jdwjdwjdw approved these changes Jan 30, 2024
View reviewed changes
Copy link

@jdwjdwjdw jdwjdwjdw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Successfully ran compiler through yarn/gitpod and everything appears to be working as expected.

@imonroe
Copy link

imonroe commented Feb 22, 2024

This seems to work fine to me.

imonroe
imonroe approved these changes Feb 22, 2024
View reviewed changes
Copy link

@imonroe imonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sherakama
Copy link
Member Author

Thanks @jdwjdwjdw and @imonroe

Anyone else? I'm going to put a due date of the 28th on this otherwise it is going to merge.

@sherakama sherakama merged commit 5a6ece1 into 1.x Feb 28, 2024
2 checks passed
@sherakama sherakama deleted the sherakama-patch-1 branch February 28, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdwjdwjdw jdwjdwjdw jdwjdwjdw approved these changes

@joegl joegl joegl approved these changes

@imonroe imonroe imonroe approved these changes

@pookmish pookmish Awaiting requested review from pookmish

@jenbreese jenbreese Awaiting requested review from jenbreese

@rebeccahongsf rebeccahongsf Awaiting requested review from rebeccahongsf

@mdyoung3 mdyoung3 Awaiting requested review from mdyoung3

Assignees
No one assigned
Labels
size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sherakama @imonroe @joegl @jdwjdwjdw