Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHEMH-274: Create .gitpod.yml #96

Merged
merged 1 commit into from
Nov 22, 2024
Merged

CHEMH-274: Create .gitpod.yml #96

merged 1 commit into from
Nov 22, 2024

Conversation

jenbreese
Copy link
Collaborator

@jenbreese jenbreese commented Oct 9, 2024

Added a gitpod.yml file.
@pookmish, if you have time to glance and make sure I didn't miss anything. I used LBRE as the example.

READY FOR REVIEW

Summary

  • Added the .gitpod.yml file.

Review By (Date)

  • when time

Criticality

  • normal

Urgency

  • normal

Review Tasks

Setup tasks and/or behavior to test

  1. go to github.
  2. launch the gitpod with the button.
  3. verify the site comes up.
  4. Verify you can sync content.

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- CHEMH-274

Resources

Added a gitpod.yml file.
@jenbreese jenbreese changed the title chemh-274: Create .gitpod.yml CHEMH-274: Create .gitpod.yml Oct 9, 2024
Copy link
Contributor

@pookmish pookmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spun up a gitpod and it does what I would expect

@buttonwillowsix buttonwillowsix merged commit 6ea5084 into 2.x Nov 22, 2024
1 check passed
@buttonwillowsix buttonwillowsix deleted the chemh-274--gitpod branch November 22, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants