Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v5.2 fixups #91

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Add v5.2 fixups #91

merged 4 commits into from
Mar 26, 2024

Conversation

jdwjdwjdw
Copy link
Contributor

@jdwjdwjdw jdwjdwjdw commented Mar 23, 2024

READY FOR REVIEW

Summary

  • CHEMH-265: Review ChEM-H subtheme for 5.2 release
  • v5.2 fixups

Review By (Date)

  • ASAP

Urgency

  • High

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Add a basic page and test out all banner combinations with their new header options
  3. Add a basic page and test out all card combinations with their new header options
  4. Add a basic page and test out list combinations with the various headline behavior. I made changes to events, news, and people cards, so make sure those are looking good. Other lists and cards should be looking good as well.
  5. Add a basic page and test out teaser combinations with the various headline behavior. I made changes to events, news, and people cards, so make sure those are looking good. Other teasers should be looking good as well.
  6. Review code ☕

Associated Issues and/or People

  • CHEMH-265: Review ChEM-H subtheme for 5.2 release

Copy link
Collaborator

@jenbreese jenbreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks G2G

@jdwjdwjdw jdwjdwjdw merged commit 9b8c491 into 2.x Mar 26, 2024
1 check passed
@jdwjdwjdw jdwjdwjdw deleted the CHEMH-265--v5.2-fixups branch March 26, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants