Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHEMH-000 | @jdwjdwjdw | Update event node styles #88

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

jdwjdwjdw
Copy link
Contributor

READY FOR REVIEW

Summary

Review By (Date)

  • ASAP

Urgency

  • High

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Add a future example event with and without event type terms, and example past event with and without event type terms
  3. Confirm that all of the terms / labels look good and are center
  4. Review code 🍜

Associated Issues and/or People

@jenbreese
Copy link
Collaborator

@jdwjdwjdw the styling all looks fine. I am seeing this drupal error. Do you see it took. It appears when editing a page.
Screenshot 2024-02-27 at 9 45 00 PM

@jdwjdwjdw
Copy link
Contributor Author

@jenbreese yes but it doesn't look to be specific to ChemH / this PR. I asked Mike and it sounds like we won't need to worry about it until Drupal 11 in 2 years.

Copy link
Collaborator

@jenbreese jenbreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG.

@jdwjdwjdw jdwjdwjdw merged commit 9fea483 into 2.x Feb 28, 2024
1 check passed
@jdwjdwjdw jdwjdwjdw deleted the CHEMH-000-events-node-fixup branch February 28, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants