Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHEMH-263: changing max width to 2000px #84

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Conversation

jenbreese
Copy link
Collaborator

@jenbreese jenbreese commented Jan 18, 2024

READY FOR REVIEW

Summary

  • Change a max-width from 1800px to 2000px on the Halfpill Title Banner and on the Halfpill Banner

Review By (Date)

  • soon

Criticality

  • Normal

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild Cache and import config drush cr ; drush ci
  3. Navigate to a page and add a halfpill title banner.
  4. Verify the max-width on the banner is now 2000px

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- CHEMH-263

Resources

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions github-actions bot added size/xs and removed size/xl labels Jan 18, 2024
@github-actions github-actions bot added size/s and removed size/xs labels Feb 6, 2024
@jenbreese
Copy link
Collaborator Author

@jdwjdwjdw Can you review this change to the title banner? I fixed up the sizes to match the standard halfpill banner. Thank you!

Copy link
Contributor

@jdwjdwjdw jdwjdwjdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to match the updated guidance from Dena in https://stanfordits.atlassian.net/browse/CHEMH-263?focusedCommentId=147615. Thanks @jenbreese

@jenbreese jenbreese merged commit bb368a6 into 2.x Feb 7, 2024
1 check passed
@jenbreese jenbreese deleted the CHEMH-263--halfpill-title branch February 7, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants