Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHEMH-262 | @jdwjdwjdw | Remove unused card button style variant #83

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

jdwjdwjdw
Copy link
Contributor

@jdwjdwjdw jdwjdwjdw commented Jan 8, 2024

READY FOR REVIEW

Summary

Review By (Date)

  • When convenient

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Add a basic page and test the card paragraph. Confirm that the Card Button Style variant is no longer an option, and no button wrapper classes are being added to new cards. All of the card buttons should still have the gradient button styles being applied.
  3. Review code 🎆

Associated Issues and/or People

Copy link
Collaborator

@jenbreese jenbreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as described for me.

@jdwjdwjdw jdwjdwjdw merged commit 497ac90 into 2.x Jan 8, 2024
1 check passed
@jdwjdwjdw jdwjdwjdw deleted the CHEMH-262--card-button-cleanup branch January 8, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants