Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHEMH-260 | @jdwjdwjdw | Update full pill banner mobile styles #80

Merged
merged 2 commits into from
Nov 21, 2023
Merged

CHEMH-260 | @jdwjdwjdw | Update full pill banner mobile styles #80

merged 2 commits into from
Nov 21, 2023

Conversation

jdwjdwjdw
Copy link
Contributor

@jdwjdwjdw jdwjdwjdw commented Nov 18, 2023 •
edited by jira bot
Loading

READY FOR REVIEW

Summary

  • CHEMH-260: New mobile treatment for full pill
    • Remove the image on mobile
    • Remove the background pattern on mobile
    • Have the background be the dark grey, end-to-end (or as close to as possible)

Review By (Date)

  • When convenient

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Add a left-aligned full pill banner to a basic page
  3. View the banner on mobile and confirm that it meets the desired specifications in the ticket
  4. Review code 🦃

Associated Issues and/or People

  • CHEMH-260: New mobile treatment for full pill

jenbreese
jenbreese approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@jenbreese jenbreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me and works like I wanted. I tested it in FF and Safari. Good to go.

src/scss/components/banner/_banner--fullpill.scss Outdated Show resolved Hide resolved
@jdwjdwjdw jdwjdwjdw merged commit 8931b05 into 2.x Nov 21, 2023
1 check passed
@jdwjdwjdw jdwjdwjdw deleted the CHEMH-260--full-pill-banner-mobile branch November 21, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenbreese jenbreese jenbreese approved these changes

Assignees

@jenbreese jenbreese

Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdwjdwjdw @jenbreese