Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHEMH-259 | @jdwjdwjdw | Adjust breakpoints for News cards for node page, lists, and teasers #79

Merged
merged 5 commits into from
Nov 14, 2023

Conversation

jdwjdwjdw
Copy link
Contributor

@jdwjdwjdw jdwjdwjdw commented Nov 2, 2023

READY FOR REVIEW

Summary

  • CHEMH-259: Adjust breakpoints for news cards
    • This addresses the breakpoints of News card for node pages, lists and teasers. At one point we were trying to go for a wider card and different image dimension, but most of that work had previously been removed because of issues that came up with fixed-width cards getting squashed into each other. Based on that, in a lot of these situations I updated it to be similar to how they behave on core. If you have different thoughts on how they should behave @jenbreese, let me know!

Review By (Date)

  • When convenient

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Build some example news items and then test how the related news cards look and behave at different breakpoints. Make sure to look at the More News cards on News node pages, as well as how News cards look for lists and teasers.
  2. Review code 🦑

Associated Issues and/or People

  • CHEMH-259: Adjust breakpoints for news cards

@jenbreese
Copy link
Collaborator

@jdwjdwjdw at about 800px wide the cards in the read more footer get too close to the edge.
Screenshot 2023-11-03 at 2 59 17 PM

@jdwjdwjdw
Copy link
Contributor Author

Thanks @jenbreese, I made some responsive updates which should address that. Should be good to re-review again.

Copy link
Collaborator

@jenbreese jenbreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the responsive works good. thanks!

@jdwjdwjdw jdwjdwjdw merged commit a7c9c57 into 2.x Nov 14, 2023
1 check passed
@jdwjdwjdw jdwjdwjdw deleted the CHEMH-259--news-card-breakpoints branch November 14, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants