Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHEMH-256 | @jdwjdwjdw | Move heading badge to be above headline instead of superhead #78

Merged
merged 3 commits into from
Oct 25, 2023
Merged

CHEMH-256 | @jdwjdwjdw | Move heading badge to be above headline instead of superhead #78

merged 3 commits into from
Oct 25, 2023

Conversation

jdwjdwjdw
Copy link
Contributor

@jdwjdwjdw jdwjdwjdw commented Oct 20, 2023 •
edited
Loading

READY FOR REVIEW

Summary

  • CHEMH-256: Change red header decoration on Half Pill title banner

Review By (Date)

  • When convenient

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Add a basic page with a top banner with the Halfpill title variant. Fill out all of the fields.
  3. Confirm that the heading badge is now above the headline instead of the superhead.
  4. Review code 🎧

Associated Issues and/or People

  • CHEMH-256: Change red header decoration on Half Pill title banner

jenbreese
jenbreese approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@jenbreese jenbreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GtG

@jdwjdwjdw jdwjdwjdw merged commit f8a2632 into 2.x Oct 25, 2023
1 check passed
@jdwjdwjdw jdwjdwjdw deleted the CHEMH-256--update-banner-heading-badge branch October 25, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenbreese jenbreese jenbreese approved these changes

Assignees

@jenbreese jenbreese

Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdwjdwjdw @jenbreese