Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHEMH-255 | @jdwjdwjdw | Fix event multi-date seperator spacing issue on mobile #76

Merged
merged 5 commits into from
Oct 25, 2023

Conversation

jdwjdwjdw
Copy link
Contributor

@jdwjdwjdw jdwjdwjdw commented Oct 20, 2023

READY FOR REVIEW

Summary

  • CHEMH-255: Events with date range spacing
    • Date range hyphen for multi-day events not evenly spaced on mobile
      image
    • Add container query to fix event card multi-date size overflow when card is squashed
      image

Review By (Date)

  • When convenient

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Add a few example events (including some multi-day events), then add a basic page with an event list card grid paragraph
  3. Review the event cards at all breakpoints and confirm that the two issues for multi-day event cards (Date range hyphen for multi-day events not evenly spaced on mobile, multi-date size overflow when card is squashed) have been addressed
  4. Review code 🥞

Associated Issues and/or People

@jenbreese
Copy link
Collaborator

jenbreese commented Oct 23, 2023

@jdwjdwjdw I'm getting some unexpected results when I test this against 11.x. When you have time, let's chat.

Copy link
Collaborator

@jenbreese jenbreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GtG

@jdwjdwjdw jdwjdwjdw merged commit f783393 into 2.x Oct 25, 2023
1 check passed
@jdwjdwjdw jdwjdwjdw deleted the CHEMH-255-multi-day-events-spacing branch October 25, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants