Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHEMH-240 | @jdwjdwjdw | Remove italics and serif, update padding-top #75

Merged
merged 6 commits into from
Nov 1, 2023
Merged

CHEMH-240 | @jdwjdwjdw | Remove italics and serif, update padding-top #75

merged 6 commits into from
Nov 1, 2023

Conversation

jdwjdwjdw
Copy link
Contributor

@jdwjdwjdw jdwjdwjdw commented Oct 13, 2023 •
edited
Loading

READY FOR REVIEW

Summary

Review By (Date)

  • When convenient

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Review Person lists, Event and News nodes, and confirm that italics and serif have been removed. For the event Node, confirm that the padding has been adjusted per Kerri's suggestion in CHEMH-252.
  3. Review code 🎃

jenbreese
jenbreese approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@jenbreese jenbreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works good for me. Just checkout if that is an extra tab space.

@jdwjdwjdw jdwjdwjdw merged commit dffb308 into 2.x Nov 1, 2023
1 check passed
@jdwjdwjdw jdwjdwjdw deleted the a11y/CHEMH-253--italics-fixups branch November 1, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenbreese jenbreese jenbreese approved these changes

Assignees

@jenbreese jenbreese

Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdwjdwjdw @jenbreese