Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHEMH-251 | @jdwjdwjdw | Fixup overlapping news cards on mobile #74

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

jdwjdwjdw
Copy link
Contributor

@jdwjdwjdw jdwjdwjdw commented Oct 13, 2023

READY FOR REVIEW

Summary

Review By (Date)

  • When convenient

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Add example news items, then add a basic page with a news item list
  3. Test out the news list at all breakpoints / browsers, and confirm that the cards now have a correct spacing between each other on mobile.
  4. Review code 🍂

Associated Issues and/or People

  • CHEMH-251: BUG | Overlapping news cards on mobile

Copy link
Collaborator

@jenbreese jenbreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me.

@jdwjdwjdw jdwjdwjdw merged commit 6796bf8 into 2.x Oct 17, 2023
1 check passed
@jdwjdwjdw jdwjdwjdw deleted the CHEMH-251--overlapping-news-cards branch October 17, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants