Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChemH-246 | @jdwjdwjdw | Add button grid #71

Merged
merged 6 commits into from
Sep 29, 2023
Merged

Conversation

jdwjdwjdw
Copy link
Contributor

@jdwjdwjdw jdwjdwjdw commented Sep 27, 2023

READY FOR REVIEW

Summary

  • CHEMH-246:Create button style for grid using either Big Button or Secondary Button
  • CHEMH-74: Button Grid

Review By (Date)

  • When convenient

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Add a basic page with a text area paragraph (one column)
  3. In the WYSIWYG, click on Source and add a div with class chemh-button-grid, and then enclose the button links within (works for big button, regular button, and secondary button). For example:
<div class="chemh-button-grid">
    <a class="su-button--big" href="https://example.com">Stanford Sites</a> <a class="su-button--big" href="/research">Faculty Fellows</a> <a class="su-button--big" href="https://sites.stanford.edu/">NIH Grant Training</a> <a class="su-button--big" href="https://sites.stanford.edu/">Stanford</a> <a class="su-button--big" href="https://sites.stanford.edu/">Staff Opportunities</a> <a class="su-button--big" href="https://example.com">Button Button</a> <a class="su-button--big" href="https://sites.stanford.edu/">Arts</a> <a class="su-button--big" href="/research">Diversity Outreach and Opportunities</a> <a class="su-button--big" href="https://example.com">Funding Opportunities</a>
</div>
  1. Confirm the button grid looks correct.
  2. Review code 🎓

Associated Issues and/or People

  • CHEMH-246:Create button style for grid using either Big Button or Secondary Button
  • CHEMH-74: Button Grid

Copy link
Collaborator

@jenbreese jenbreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you.

@jdwjdwjdw jdwjdwjdw merged commit b1453cb into 2.x Sep 29, 2023
1 check passed
@jdwjdwjdw jdwjdwjdw deleted the CHEMH-246--button-grid branch September 29, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants