Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHEMH-247: updated to the not pro font and updated decanter version #70

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

jenbreese
Copy link
Collaborator

READY FOR REVIEW

Summary

  • Removed the direct reference to Source Sans Pro
  • Updated it to the sans variable from Decanter
  • Updated Decanter version.

Review By (Date)

  • 9/20

Criticality

  • Normal

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild Cache and import config drush cr ; drush ci
  3. Navigate to a page with headings and font
  4. Verify the fonts are no longer than the pro version.
  5. Verify it has the updated footer links to the Non-Discrimination and the rel=nofollow

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory? NO

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- CHEMH-247

Resources

Copy link
Contributor

@jdwjdwjdw jdwjdwjdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decanter update looks good. Just one comment / clarification.

Comment on lines 4 to 6
h1, h2, h3, h4, h5 {
font-family: 'Source Sans Pro';
font-family: $su-font-sans;
}
Copy link
Contributor

@jdwjdwjdw jdwjdwjdw Sep 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the font-family still need to be specified here for the headings? It looks like the headings are getting this font-family inherited from the html already.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All done.

Copy link
Contributor

@jdwjdwjdw jdwjdwjdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - looking good!

@jenbreese jenbreese merged commit 67c2d8c into 2.x Sep 21, 2023
@jenbreese jenbreese deleted the CHEMH-247--font-decanter-update branch September 21, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants