generated from SU-SWS/stanford_starter
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHEMH-77: A fullpill banner #68
Merged
Merged
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ed00057
CHEMH-77: setup for a horizontal full pill card.
jenbreese d416bdc
stashing
jenbreese 5576424
CHEMH-77: working on fullpill banner or card
jenbreese 29dd50f
CHEMH-77: fixups
jenbreese f47c236
fixup
jenbreese 58adc64
CHEMH-77: creating a fullpill banner
jenbreese e1e9114
fixup
jenbreese 08748b2
fixup
jenbreese 001b1eb
CHEMH-77: fixup to the banner padding and the button background
jenbreese b45f645
fixup
jenbreese 3202474
fixup
jenbreese cfd0b44
fixup
jenbreese 54b7780
fixup
jenbreese 835cea5
merge
jenbreese b714548
merge
jenbreese File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Large diffs are not rendered by default.
Oops, something went wrong.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,143 @@ | ||
@charset "UTF-8"; | ||
|
||
$banner-circle--image-width: 200px; | ||
$banner-circle--sm-image-width: 150px; | ||
|
||
|
||
.chemh-wrapper--banner-fullpill { | ||
max-width: calc(100vw - 200px); | ||
margin: 0 auto; | ||
|
||
.su-hero { | ||
background: $su-color-black url("../../assets/svg/fullpill-bg.svg") no-repeat 100% / 200%; | ||
border-radius: 300px; | ||
color: $su-color-white; | ||
flex-direction: row; | ||
justify-content: flex-start; | ||
align-items: center; | ||
min-height: 400px; | ||
|
||
@include grid-media-max('md') { | ||
background: $su-color-black url("../../assets/svg/fullpill-bg.svg") no-repeat 100% / 205%; | ||
|
||
@include modular-spacing('padding', 3); | ||
} | ||
|
||
@include grid-media-max('sm') { | ||
background-size: cover; | ||
} | ||
|
||
@include modular-spacing('padding-top', 3); | ||
@include modular-spacing('padding-bottom', 3); | ||
|
||
|
||
|
||
.su-hero__media { | ||
background: transparent; | ||
margin-left: 5%; | ||
min-height: unset; | ||
position: unset; | ||
height: unset; | ||
width: unset; | ||
|
||
img { // Image display has been set to media image style - Medium (220) | ||
@include modular-spacing('margin-bottom', -2); | ||
|
||
border-radius: 50%; | ||
width: $banner-circle--image-width; | ||
height: $banner-circle--image-width; | ||
margin-left: auto; | ||
margin-right: auto; | ||
object-fit: cover; | ||
padding: 0; | ||
|
||
@include grid-media-max('sm') { | ||
width: $banner-circle--sm-image-width; | ||
height: $banner-circle--sm-image-width; | ||
} | ||
} | ||
} | ||
|
||
.su-card { | ||
&.su-hero__card { | ||
background: transparent; | ||
border: none; | ||
bottom: unset; | ||
box-shadow: none; | ||
left: unset; | ||
margin-top: unset; | ||
margin-bottom: unset; | ||
max-width: unset; | ||
top: unset; | ||
|
||
& > .image { | ||
@include grid-media-min('sm') { | ||
max-width: $banner-circle--image-width; | ||
min-width: $banner-circle--image-width; | ||
|
||
margin-left: 50px; | ||
|
||
img { | ||
border-radius: 50%; | ||
} | ||
} | ||
|
||
} | ||
|
||
.su-card__contents { | ||
|
||
h2 { | ||
@include responsive-spacing('margin-bottom', -1); | ||
@include chemh-heading--badge; | ||
@include type-a; | ||
|
||
color: $su-color-white; | ||
font-family: $su-font-sans; | ||
|
||
} | ||
|
||
.su-card__link, | ||
.su-card__button { | ||
@include responsive-spacing('margin-top', 3); | ||
} | ||
} | ||
} | ||
|
||
} | ||
} | ||
|
||
// Link colors. | ||
div { | ||
.su-button, | ||
.su-card__button { | ||
a { | ||
background-color: $su-color-black; | ||
color: $su-color-white; | ||
} | ||
} | ||
} | ||
|
||
.su-button:not(.su-link--external):after, | ||
.su-button:not(.su-link--external):after { | ||
background: url(../../assets/svg/icon_east_white.svg) no-repeat 0 0; | ||
} | ||
} | ||
|
||
|
||
// when on a page with a sidebar nav, needs adjustments: | ||
.jumpstart-ui--two-column.centered-container { | ||
.flex-lg-9-of-12.main-region { | ||
.su-hero { | ||
// when on a sidebar-nav page, needs less bottom spacing | ||
@include modular-spacing('padding-bottom', 5); | ||
|
||
.su-card__contents { | ||
// @apply mx-auto; | ||
max-width: 90%; | ||
@include grid-media-min('lg') { | ||
max-width: 80%; | ||
} | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
@charset "UTF-8"; | ||
|
||
|
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
@charset "UTF-8"; | ||
|
||
// Card Roll Up | ||
|
||
@import 'minimal-border'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
@charset "UTF-8"; | ||
|
||
// Max-width variables for _banner-in-page--no-image.scss | ||
$banner-b--lg: 864px; | ||
$banner-b--xl: 1024px; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,3 +8,4 @@ | |
|
||
@import 'colors'; | ||
@import 'magic-numbers'; | ||
@import 'sizes'; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this max-width constraint is causing some issues for mobile, can you address that?