Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHEMH-40 | @jdwjdwjdw | Update individual Person teasers #63

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

jdwjdwjdw
Copy link
Contributor

@jdwjdwjdw jdwjdwjdw commented Aug 11, 2023

READY FOR REVIEW

Summary

  • Adjust individual person teaser styles when added to section with multiple columns in order to fix issue seen at https://chemhsubtheme.sites.stanford.edu/about/rm-test-page-1
  • Adjust individual person teaser styles in one column layout to stack in the same way as the other teasers (photo on top of card contents)
  • Fixup to ensure teaser style changes are specific to person teasers only

Review By (Date)

  • When convenient

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Add a basic page and test out adding one teaser for one, two, and three column layouts. Confirm they look correct and all stack in the same way (photo on top of card contents)
  3. Add a non-person teaser and confirm that none of the styles being applied here are reflected on that non-person teaser.
  4. Review code ☕

Associated Issues and/or People

  • CHEMH-40: Person teaser styling
  • CHEMH-243: Deploy people teaser and person node page for review

@github-actions github-actions bot added size/s and removed size/xs labels Aug 16, 2023
Copy link
Collaborator

@jenbreese jenbreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described.

@jdwjdwjdw jdwjdwjdw merged commit 90ec781 into 2.x Aug 17, 2023
@jdwjdwjdw jdwjdwjdw deleted the CHEMH-000--person-fixups branch August 17, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants