-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHEMH-89 | @jdwjdwjdw | Style event node and teaser #55
Conversation
@jdwjdwjdw I started looking at it. In the phone views, the headings and related topics seem really big. |
Thanks Jen! It looks like all of our headings have a fixed rem font-size currently (see
It looks like the difference between the card gaps for lists and teasers is due to lists using CSS Grid, and teasers using Flexbox, which matches what's currently on Stanford Basic (see https://amptesting.sites.stanford.edu/sws-test-922-events-lists-teasers). I'm not sure how much work it would take to change that, but is probably something that should be done on Stanford Basic is we do decide to update that. |
@jdwjdwjdw I think we update to the Decanter typography. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it this morning and the fonts are much better. I agree about the card layout coming from SB instead of just fixing here.
READY FOR REVIEW
Summary
Review By (Date)
Urgency
Review Tasks
Setup tasks and/or behavior to test
Associated Issues and/or People