Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHEMH-73 | @jdwjdwjdw | Structure and style Person node, lists, and teasers #53

Merged
merged 19 commits into from
Aug 7, 2023
Merged

CHEMH-73 | @jdwjdwjdw | Structure and style Person node, lists, and teasers #53

merged 19 commits into from
Aug 7, 2023

Conversation

jdwjdwjdw
Copy link
Contributor

@jdwjdwjdw jdwjdwjdw commented May 26, 2023 •
edited by jira bot
Loading

READY FOR REVIEW

Summary

Review By (Date)

  • When convenient

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Add example people
  3. Add a basic page with person list and person teasers
  4. Review Person node page, person lists, and person teasers and confirm they match figma. In order for the stanford default person image to look correct, you'll need to update that to a square version:
    stanford-person-default-profile-image-square (1)
  5. Review code 🚗

Associated Issues and/or People

@github-actions github-actions bot added size/s and removed size/xs labels Jun 6, 2023
@jdwjdwjdw jdwjdwjdw changed the title CHEMH-73 | @jdwjdwjdw | Structure and style Person node CHEMH-73 | @jdwjdwjdw | Structure and style Person node, lists, and teasers Aug 7, 2023
jenbreese
jenbreese approved these changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@jenbreese jenbreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks awesome. I tested in safari, FF and chrome.

src/js/chem_h_subtheme.behaviors.js Show resolved Hide resolved
@jdwjdwjdw jdwjdwjdw merged commit f6cdf82 into 2.x Aug 7, 2023
@jdwjdwjdw jdwjdwjdw deleted the feature/CHEMH-73--style-people-node branch August 7, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenbreese jenbreese jenbreese approved these changes

Assignees

@jenbreese jenbreese

Labels
size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdwjdwjdw @jenbreese @pookmish