Add v5.2 fixups

SU-SWS · Mar 23, 2024 · 3f19f79 · 3f19f79
1 parent c12f27c
commit 3f19f79
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 10 deletions.
diff --git a/dist/css/chem_h_subtheme.css b/dist/css/chem_h_subtheme.css
diff --git a/src/js/chem_h_subtheme.behaviors.js b/src/js/chem_h_subtheme.behaviors.js
@@ -33,6 +33,9 @@
 
       // Heading change for the halfpill title banner.
       $('.chemh-wrapper--banner-halfpill-title h2').contents().unwrap().wrap('<h1/>');
+      $('.chemh-wrapper--banner-halfpill-title h3').contents().unwrap().wrap('<h1/>');
+      $('.chemh-wrapper--banner-halfpill-title h4').contents().unwrap().wrap('<h1/>');
+      $('.chemh-wrapper--banner-halfpill-title .su-font-splash').contents().unwrap().wrap('<h1/>');
 
       // Bckground color needed on only the Halfpill title banner.
       $('.chemh-wrapper--banner-halfpill-title').parents().find('.su-page-banner').addClass('su-page-banner--title');

diff --git a/src/scss/components/banner/_banner--fullpill.scss b/src/scss/components/banner/_banner--fullpill.scss
@@ -98,11 +98,16 @@ $banner-circle--sm-image-width: 150px;
         }
 
         .su-card__contents {
-
           h2 {
+            @include type-a;
+          }
+
+          h2,
+          h3,
+          h4,
+          .su-font-splash {
             @include responsive-spacing('margin-bottom', -1);
             @include chemh-heading--badge;
-            @include type-a;
 
             color: $su-color-white;
             font-family: $su-font-sans;

diff --git a/src/scss/theme/_headings.scss b/src/scss/theme/_headings.scss
@@ -22,7 +22,6 @@ h2 {
 h3 {
   @include type-b;
   font-weight: $su-font-bold;
-  line-height: 5.2rem;
   /* identical to box height, or 149% */
   letter-spacing: -1.5px;
   color: $chemh-color-true-black;
@@ -31,7 +30,6 @@ h3 {
 h4 {
   @include type-c;
   font-weight: $su-font-bold;
-  line-height: 3.8rem;
   /* identical to box height, or 136% */
   letter-spacing: -1px;
   color: $chemh-color-true-black;
@@ -40,7 +38,6 @@ h4 {
 h5 {
   @include type-c;
   font-weight: $su-font-bold;
-  line-height: 3.8rem;
   /* identical to box height, or 136% */
   letter-spacing: -1px;
   color: $chemh-color-true-black;

diff --git a/src/scss/theme/_links.scss b/src/scss/theme/_links.scss
@@ -145,7 +145,8 @@ a {
             background-color: $chemh-color-digital-blue;
           }
 
-          h2 {
+          h2,
+          h3 {
             color: $chemh-color-digital-blue;
           }
         }
@@ -155,7 +156,8 @@ a {
       &:focus {
         color: $chemh-color-digital-blue;
 
-        h2 {
+        h2,
+        h3 {
           color: $chemh-color-digital-blue;
         }
       }

diff --git a/templates/components/news-vertical-teaser/news-vertical-teaser.html.twig b/templates/components/news-vertical-teaser/news-vertical-teaser.html.twig
@@ -38,6 +38,7 @@
 {%- endif -%}
 
 {% set news_url = news_url|render|striptags("<drupal-render-placeholder>")|trim %}
+{% set header_tag = variant == 'h3_header' ? 'h3' : 'h2' %}
 
 <article{{ attributes.addClass(classes) }}>
   {%- if news_url is not empty -%}
@@ -59,9 +60,9 @@
     {%- if news_url is not empty -%}
       <a {{ news_url_attributes.addClass('su-news-vertical-teaser__link') }} href="{{ news_url }}">
     {%- endif -%}
-      <h2 class="su-link su-card__link">
+      <{{ header_tag }} class="su-link su-card__link">
         {{- news_vertical_teaser_headline -}}
-      </h2>
+      </{{ header_tag }}>
       {%- if news_url is not empty -%}
       </a>
     {%- endif -%}